[prometheus-node-exporter] remove ns from clusterrole #3844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: drfaust92 <[email protected]>
DrFaust92
requested review from
gianrubio,
zanhsieh and
zeritti
as code owners
Signed-off-by: zeritti <[email protected]>
Signed-off-by: zeritti <[email protected]>
zeritti
approved these changes
Sep 30, 2023
There was a problem hiding this comment.
Thank you, @DrFaust92, for your PR. I have attached a few corrections in README.
Matiasmct
pushed a commit
to giffgaff/prometheus-charts-backup
that referenced
this pull request
Mar 20, 2024
…munity#3844) * remove ns from cluster role Signed-off-by: drfaust92 <[email protected]> * Remove notes on minor changes from README Signed-off-by: zeritti <[email protected]> * Fix linting errors Signed-off-by: zeritti <[email protected]> --------- Signed-off-by: drfaust92 <[email protected]> Signed-off-by: zeritti <[email protected]> Co-authored-by: zeritti <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer
Checklist
[prometheus-couchdb-exporter])